linux/rpath: fix relative path finding for symlinked dirs #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses the note mentioned here: |
HamedSabri-adsk
added
the
do-not-merge-yet
|
@elrond79 what's the simplest way to reproduce the issue using our build script? |
|
This was on Linux - add args (ie, --pxrusd-location, etc) as needed to find your dependencies. The above build should appear to complete successfully - however, if you inspect some of the libs, you'll see they have linking problems - ie: ...which should show: You can also inspect the RUNPATH directly, to see that it's going up the wrong number of directories: |
kxl-adsk
requested review from
ppt-adsk
and removed request for
HamedSabri-adsk
ppt-adsk
approved these changes
Feb 5, 2020
kxl-adsk
removed
the
do-not-merge-yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes linking issues if you happen to have a symlink as part of your build path.
Previously, mayaUsd_add_rpath would use "realpaths" when comparing to origin, but mayaUsd_init_rpath would ONLY use a realpath if the argument was originally a relative path. Thus, if you fed in an absolute path with a symlink, you would end up comparing a symlink path to a realpath.